CSS Help anyone?

guddler

Busting vectors like it's 1982!
vacBacker
Feedback
10 (100%)
Credits
4,055CR
I inherited a very large project a while back and there's no-one about to ask why things are the way they are etc.

There's CSS files that are throwing up loads of errors due to empty elements.

Anyone have any idea why you might do this (note font-weight and font-style):

Code:
.wufoo .info h2{

	font-size:160%;

	font-family:inherit;

	font-weight:;

	font-style:;

	color:#000000;

}
 

muddymusic

The Repro Guy. Art and Parts supplier
Staff member
vacBacker
Feedback
52 (100%)
Credits
2,214CR
Might just be left for ease of adding in values later during development or the values were deleted in dreamweaver etc and the tags were left behind, you can get rid.
 

guddler

Busting vectors like it's 1982!
vacBacker
Feedback
10 (100%)
Credits
4,055CR
Thanks for that. I've done a bit of digging, the file in question is part of a JavaServer Facelets implementation. Before I go ahead and get rid, could that have any bearing?
 

muddymusic

The Repro Guy. Art and Parts supplier
Staff member
vacBacker
Feedback
52 (100%)
Credits
2,214CR
I don't know much about Javaserver facelets...could they be blank for the facelets script to fill in? although i'd expect to see a server call where the blank value is though.
 

guddler

Busting vectors like it's 1982!
vacBacker
Feedback
10 (100%)
Credits
4,055CR
Sadly, I don't know much about it all either. Having inherited this project though, it's all way higher on the list of stuff to suss out than I would have liked
smiley5.gif


Really, that's my concern, removing it may screw up the JSF, but like you, I'd have thought the JSF would need some kind of tag to know where it's meant to be inserting stuff and where it's not? It wouldn't be the first time I've seen stuff that to the untrained eye (like mine) it just looks like voodoo. Apple stuff is full of things like that. Compilers that magically do things just based on functions being named in a particular way. Guess I need to dig out some learning materials!

I guess, until I understand it at least a little better I suppose I better leave it be. It just goes against the grain to release a project with nearly a 1,000 errors listed in it, regardless of whether it works or not. Especially when I'm the manager of the team! I may get some time to just locate the file in the web app and experiment locally
smiley1.gif
 

muddymusic

The Repro Guy. Art and Parts supplier
Staff member
vacBacker
Feedback
52 (100%)
Credits
2,214CR
I've not seen scripts that add to blank css values before, you'd always have to have code marked with a tag like said - if the css is in a linked stylesheet then that won't be written to by the script, however if the css is inline then it could be but i'd still expect to see marked tags - but yes, things we might not be aware of could be done with jsf and I wouldn't like to say for certain what it's up to.

Go for a local test and see if the generated page still throws up the errors, it's always tricky getting work on someone elses code...i've taken on some stuff that I have no clue why things have been written as they have and other times where i've learnt a few useful tricks. Having to learn a whole new JS app is a pain in the ass every time!
smiley1.gif
 

muddymusic

The Repro Guy. Art and Parts supplier
Staff member
vacBacker
Feedback
52 (100%)
Credits
2,214CR
From the example you gave it could be used to set text as normal for one value, italic for another etc., in normal circumstances you'd have different css tags called for different values from the JS though - that's the way i've always done things - the script calls the css - not the other way round. It's just if there are hundreds of these blank values I'm suddenly not sure it can't be done the other way round
smiley5.gif
 
Top